Skip to content

Conversation

@refack
Copy link
Contributor

Checklist
Affected core subsystem(s)

build,tools

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 24, 2017
@refackrefack added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels May 24, 2017
@refack
Copy link
ContributorAuthor

/cc @nodejs/platform-windows @nodejs/build

@refackrefack requested a review from joshgavMay 24, 2017 21:29
@refackrefack self-assigned this May 24, 2017
@gibfahn
Copy link
Member

What does *.exe match in the top level?

@refack
Copy link
ContributorAuthor

for all sort of scripts we need ./node to be resolvable

@gibfahn
Copy link
Member

for all sort of scripts we need ./node to be resolvable

I thought all the scripts used Release\node.exe for windows

@refack
Copy link
ContributorAuthor

I started using make lint

@Fishrock123
Copy link
Contributor

I started using make lint

Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

@refack
Copy link
ContributorAuthor

refack commented May 25, 2017

I started using make lint
Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

The commands in Makefile assume NODE ?= ./$(NODE_EXE), so if I want to enjoy them I need to either symlink the exe, or keep specifying NODE=...
P.S. I'm using MSYS make in a regular (non WSL) environment.

@refackrefack closed this May 27, 2017
@refackrefackforce-pushed the ignore-vs-artifacts branch from 164b836 to c1a4b53CompareMay 27, 2017 21:09
@refackrefack merged commit c1a4b53 into nodejs:masterMay 27, 2017
@refack
Copy link
ContributorAuthor

Landed c1a4b53

@refackrefack deleted the ignore-vs-artifacts branch May 27, 2017 21:27
jasnell pushed a commit that referenced this pull request May 28, 2017
PR-URL: #13208 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnelljasnell mentioned this pull request May 28, 2017
@refackrefack removed their assignment Jun 12, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
PR-URL: #13208 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@refack@gibfahn@Fishrock123@jasnell@cjihrig@MylesBorins@nodejs-github-bot