Skip to content

Conversation

@gibfahn
Copy link
Member

If you don't have the full Xcode installed, the command-line tools are
all you need.

Fixes: #6449
Refs: #9215

cc/ @nodejs/platform-macos

Checklist
Affected core subsystem(s)

doc, build

@gibfahngibfahn added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. macos Issues and PRs related to the macOS platform / OSX. labels May 28, 2017
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 28, 2017
@gibfahngibfahn requested review from Trott, mscdex and targosMay 28, 2017 11:12
@gibfahn
Copy link
MemberAuthor

@mscdex cf: #9215 (comment)

How far back does xcode-select --install work for older versions of Xcode? I don't really mind either way, I just thought it might be useful to keep instructions for new and old if the instructions will differ.

It looks like it works from 10.9 (mavericks), so I think we should be fine. IMHO it's unnecessary to go into any more detail, or to consider the full Xcode install for Xcode 7.x, we can always reconsider if someone has an issue.

BUILDING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reword this a bit? At the moment it says "On macOS, you will also need -> Xcode -> You also need to install the Xcode Command Line Tools ...".

A full installation of Xcode is not required, so maybe this can be changed to

On macOS, you will also need:

  • The Xcode Command Line Tools ...

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, PTAL.

@gibfahngibfahnforce-pushed the xcode-tools branch 2 times, most recently from d2bc186 to 93f8ecfCompareMay 28, 2017 13:57
BUILDING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems confusing. Should I run the command line or should I open the GUI and "find them"? (I imagine the answer is "either will work" but I'm not sure that's clear from this text. If xcode-select --install will work everywhere all the time, then maybe let's just leave it at that? Or preface the GUI content with "Alternatively, " so that people know it's one or the other?

@Trott
Copy link
Member

Can someone who doesn't have the full XCode installed confirm that this actually works (that is, they can compile node this way)?

@lpinca
Copy link
Member

lpinca commented May 28, 2017

@Trott can confirm I've always used this way.

@gibfahn
Copy link
MemberAuthor

gibfahn commented Jun 3, 2017

Or preface the GUI content with "Alternatively, " so that people know it's one or the other?

@Trott I went with this. Technically you can install both and switch between them with xcode-select --switch /path, but that's TMI.

LGTY?

BUILDING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comma after Alternatively

BUILDING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comma after installed

@Trott
Copy link
Member

Trott commented Jun 3, 2017

LGTY?

Text looks good to me. (Left a couple of punctuation nits, but whatever.) I don't know enough about the actual correctness of the content to provide a review/approval. I don't doubt that it's correct, but I'm not knowledgable enough to put a stamp on it. If you and @lpinca both say it's correct, that's good enough for me.

@gibfahngibfahnforce-pushed the xcode-tools branch 3 times, most recently from 8c686ca to 7c3cc26CompareJune 3, 2017 18:39
If you don't have the full Xcode installed, the command-line tools are all you need. PR-URL: nodejs#13264Fixes: nodejs#6449 Refs: nodejs#9215 Reviewed-By: Luigi Pinca <[email protected]>
@gibfahngibfahn merged commit fc102d0 into nodejs:masterJun 3, 2017
@gibfahngibfahn deleted the xcode-tools branch June 3, 2017 18:44
jasnell pushed a commit that referenced this pull request Jun 5, 2017
If you don't have the full Xcode installed, the command-line tools are all you need. PR-URL: #13264Fixes: #6449 Refs: #9215 Reviewed-By: Luigi Pinca <[email protected]>
@jasnelljasnell mentioned this pull request Jun 5, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
If you don't have the full Xcode installed, the command-line tools are all you need. PR-URL: #13264Fixes: #6449 Refs: #9215 Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.macosIssues and PRs related to the macOS platform / OSX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gibfahn@Trott@lpinca@MylesBorins@nodejs-github-bot