deps: upgrade npm to 5.0.0#13276
Closed
deps: upgrade npm to 5.0.0 #13276
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the npm 
Member
jasnell commented May 29, 2017
@nodejs/ctc @nodejs/collaborators @nodejs/npm ... we'll need to fast track this to land today in order to make it in to the 8.0.0 release. |
Contributor
Fishrock123 commented May 29, 2017
Taking a look now. |
Contributor
Fishrock123 commented May 29, 2017
Seems good. As a note, more tests are now skipped on my machine: Previously, only one was. (The couchdb one(s) I think.) |
Fishrock123 approved these changes May 29, 2017
Contributor
Fishrock123 left a comment
Fishrock123 left a comment There was a problem hiding this comment.
(That was not the button I was looking for.)
Member
addaleax commented May 29, 2017
Landed in c58cea5 |
jasnell pushed a commit that referenced this pull request May 29, 2017
PR-URL: #13276 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
ContributorAuthor
zkat commented May 29, 2017
The skipped tests are pretty safe. They're just placeholders in @iarna's file specifier tests that haven't been filled in yet. |
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
depsDescription of Changes
This is the final version of
[email protected]! It's pretty much the same as thebeta.56release that was submitted before, but has some bugfixes from the rest of the beta. We went kinda fast so I don't have a concrete list of changes since then, but you can check the new changelog for overall details.Please note that npm5 is a major update to npm, and is still fairly young. I fully expect users to find all sorts of doozies, even after a month of beta, and even longer of internal testing. We'll be doing tighter release cycles while npm5 stabilizes, though, and
update-notifiershould help users keep up to date even if new versions take a few more days to land in node@8. This is mostly a general comment about Super Fresh™ software.I want to thank y'all on the node team for keeping this window open and being communicative with the npm team about your needs/expectations. I feel pretty good about this release even with the deadline having been so tight. 🎉
Note: tomorrow is a company holiday, but I've shifted my day off to Friday so I can be available to help get this release out the door. Please do let me know if you ned anything.
Changelog
v5.0.0