test: consolidate n-api test addons#13317
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It takes time to build each of the addons used to test n-api. Consolidate a few of the smaller ones to save build time.
nodejs-github-bot added node-api 
jasongin approved these changes May 30, 2017
jasnell approved these changes May 30, 2017
gibfahn approved these changes May 31, 2017
cjihrig approved these changes May 31, 2017
MemberAuthor
mhdawson commented Jun 1, 2017
MemberAuthor
mhdawson commented Jun 1, 2017
AIX failure is not related, open this issue to track: #13377 |
MemberAuthor
mhdawson commented Jun 1, 2017
Landed as 7a7ac1c |
mhdawson added a commit that referenced this pull request Jun 1, 2017
It takes time to build each of the addons used to test n-api. Consolidate a few of the smaller ones to save build time. PR-URL: #13317 Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Jun 5, 2017
It takes time to build each of the addons used to test n-api. Consolidate a few of the smaller ones to save build time. PR-URL: #13317 Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
3 tasks
3 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
It takes time to build each of the addons used to test n-api. Consolidate a few of the smaller ones to save build time. PR-URL: nodejs#13317 Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
It takes time to build each of the addons used to test n-api. Consolidate a few of the smaller ones to save build time. Backport-PR-URL: #19447 PR-URL: #13317 Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It takes time to build each of the addons used to test n-api.
Consolidate a few of the smaller ones to save build time.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api