doc: add require modules in url.md#13365
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
vsemozhetbyt approved these changes Jun 1, 2017
cjihrig approved these changes Jun 1, 2017
gibfahn approved these changes Jun 1, 2017
jasnell approved these changes Jun 1, 2017
To make the example codes in URL doc work without additional codes, it should have more lines to require modules.
ContributorAuthor
watilde commented Jun 3, 2017
Rebased and run lint ci: https://ci.nodejs.org/job/node-test-linter/9578/. |
ContributorAuthor
watilde commented Jun 3, 2017
Landed in 917f86e. Thanks. |
watilde added a commit that referenced this pull request Jun 3, 2017
To make the example codes in URL doc work without additional codes, it should have more lines to require modules. PR-URL: #13365 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
jasnell pushed a commit that referenced this pull request Jun 5, 2017
To make the example codes in URL doc work without additional codes, it should have more lines to require modules. PR-URL: #13365 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the example codes in URL doc work without additional codes, it should have more lines to require modules.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc