Skip to content

Conversation

@seishun
Copy link
Contributor

Checklist
Affected core subsystem(s)

build

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 2, 2017
Copy link
Member

@gibfahngibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pile on LGTM

PR-URL: #13396 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@seishunseishun closed this Jun 2, 2017
@seishunseishun merged commit 3fe980d into nodejs:masterJun 2, 2017
jasnell pushed a commit that referenced this pull request Jun 5, 2017
PR-URL: #13396 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnelljasnell mentioned this pull request Jun 5, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
@seishunseishun deleted the vcbuild-typo branch October 19, 2017 20:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@seishun@cjihrig@tniessen@vsemozhetbyt@gibfahn@MylesBorins@nodejs-github-bot