Skip to content

Conversation

@tniessen
Copy link
Member

As we explicitely state that hostname is an alias for host, we should avoid passing different (or even invalid) values for host, even if hostname is preferred. There is no reason to pass an invalid value for host to http.request().

Ref: #10638

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@tniessentniessen added http Issues or PRs related to the http subsystem. semver-minor PRs that contain new features and should be released in the next minor version. url Issues and PRs related to the legacy built-in url module. labels Jun 2, 2017
@nodejs-github-botnodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 2, 2017
@addaleax
Copy link
Member

Could you explain how this is semver-minor? How does it add something to the API?

@DavidTPate
Copy link

Yeah, this doesn't appear to be a semver-minor the changes are internal and don't impact the external APIs.

@jasnell
Copy link
Member

semver-patch is appropriate here.

@jasnelljasnell removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 2, 2017
@tniessen
Copy link
MemberAuthor

Sorry, my bad, must have mixed that up with another PR.

@tniessen
Copy link
MemberAuthor

tniessen added a commit that referenced this pull request Jun 4, 2017
@tniessen
Copy link
MemberAuthor

Landed in 4d89e3c.

@tniessentniessen closed this Jun 4, 2017
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@jasnelljasnell mentioned this pull request Jun 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

httpIssues or PRs related to the http subsystem.urlIssues and PRs related to the legacy built-in url module.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen@addaleax@DavidTPate@jasnell@nodejs-github-bot