test: refactor test-dgram-oob-buffer#13443
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why.
Trott added dgram 
addaleax approved these changes Jun 3, 2017
gibfahn approved these changes Jun 3, 2017
Member
gibfahn left a comment
gibfahn left a comment There was a problem hiding this comment.
address.port looked pretty weird tbh
cjihrig approved these changes Jun 3, 2017
lpinca reviewed Jun 4, 2017
| socket.send(buf,0,4,address.port,address.address,common.noop); | ||
| socket.send(buf,1,3,address.port,address.address,common.noop); | ||
| socket.send(buf,3,1,address.port,address.address,common.noop); | ||
| socket.send(buf,0,0,port,address,common.mustNotCall()); |
Member
There was a problem hiding this comment.
Shouldn't the callback be called in all cases?
Contributor
There was a problem hiding this comment.
Perhaps something like assert.ifError would be better here.
MemberAuthor
There was a problem hiding this comment.
The socket.close() on line 43 cancels the callbacks.
MemberAuthor
There was a problem hiding this comment.
Looking at the original test at defa637378a it seems like this test may no longer have the same meaning originally intended. It seems to me that the key point was the assert.throws() calls. However, they no longer throw.
jasnell approved these changes Jun 4, 2017
Member
mhdawson commented Jun 6, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jun 7, 2017
* Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why. PR-URL: nodejs#13443 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MemberAuthor
Trott commented Jun 7, 2017
Landed in 6b07065 |
jasnell pushed a commit that referenced this pull request Jun 7, 2017
* Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why. PR-URL: #13443 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
3 tasks
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
* Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why. PR-URL: #13443 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
* Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why. PR-URL: #13443 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
This was referenced Sep 5, 2017
Trott deleted the yes-i-only-used-destructuring-to-avoid-exceeding-80-chars-in-a-line branch Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invoked.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test dgram