deps: backport c0f1ff2 from upstream V8#13517
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the v8 engine 
Member
bnoordhuis commented Jun 7, 2017
If it's still an issue, it should be fixed upstream first. |
octoploid commented Jun 7, 2017
Well, the standard upstream response is: »Do we care about gcc?« |
Member
Isn't V8 built with cc/ @nodejs/v8 |
Member
bnoordhuis commented Jun 7, 2017
Yes, there is at least one gcc buildbot, although it probably uses gcc 6, not 7. |
octoploid commented Jun 10, 2017
MemberAuthor
targos commented Jun 12, 2017
Trying to upstream the change: https://chromium-review.googlesource.com/c/530227/ /cc @fhinkel |
jasnell previously approved these changes Jun 13, 2017
MemberAuthor
targos commented Jun 19, 2017
I'm still waiting for a review upstream. |
Member
bnoordhuis commented Jun 19, 2017
Maybe pick another reviewer? |
MemberAuthor
targos commented Jun 20, 2017
@octoploid@bnoordhuis Could you please take a look at my last patch: https://chromium-review.googlesource.com/c/530227/3 |
Please post an updated patch for Node.js. |
Member
bnoordhuis commented Jun 20, 2017
@octoploid It's going upstream first before it goes into node. @targos Left a comment on the CL. |
octoploid commented Jun 20, 2017
@bnoordhuis: Sure, it is just that I don't have v8 (or chromium) installed on my test machines. |
Member
bnoordhuis commented Jun 20, 2017
@octoploid Just |
MemberAuthor
targos commented Jun 20, 2017
The change landed on V8 master: v8/v8@c0f1ff2 I will update this PR with a backport |
targos changed the title 
Original commit message: Fix GCC 7 build errors BUG=chromium:691681 [email protected] Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#46045} Fixes: nodejs#10388
MemberAuthor
targos commented Jun 20, 2017
Updated to a backport. PTAL. |
octoploid commented Jun 20, 2017
Works fine. Thanks. |
bnoordhuis approved these changes Jun 20, 2017
MemberAuthor
targos commented Jun 22, 2017
targos added a commit to targos/node that referenced this pull request Jun 23, 2017
Original commit message: Fix GCC 7 build errors BUG=chromium:691681 [email protected] Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#46045} PR-URL: nodejs#13517Fixes: nodejs#10388 Refs: nodejs#12392 Reviewed-By: Ben Noordhuis <[email protected]>
MemberAuthor
targos commented Jun 23, 2017
Landed in 0ba74db |
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Aug 1, 2017
Original commit message: Fix GCC 7 build errors BUG=chromium:691681 [email protected] Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#46045} PR-URL: nodejs#13517Fixes: nodejs#10388 Refs: nodejs#12392 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Aug 1, 2017
Original commit message: Fix GCC 7 build errors BUG=chromium:691681 [email protected] Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#46045} Refs: nodejs#13517Fixes: nodejs#10388 Refs: nodejs#12392 PR-URL: nodejs#14004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 1, 2017
Original commit message: Fix GCC 7 build errors BUG=chromium:691681[email protected] Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{#46045} Refs: #13517Fixes: #10388 Refs: #12392 PR-URL: #14004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 2, 2017
Original commit message: Fix GCC 7 build errors BUG=chromium:691681[email protected] Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{#46045} Refs: #13517Fixes: #10388 Refs: #12392 Backport-PR-URL: #14574 Backport-Reviewed-By: Anna Henningsen <[email protected]> Backport-Reviewed-By: Refael Ackermann <[email protected]> PR-URL: #14004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting #12392 to V8 5.9
Ref: #12392
Fixes: #10388
/cc @nodejs/v8 @bnoordhuis@octoploid
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8