Skip to content

Conversation

@targos
Copy link
Member

Update to current 5.9-lkgr

@nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 12, 2017
@targostargos mentioned this pull request Jun 12, 2017
2 tasks
@targos
Copy link
MemberAuthor

@jasnell
Copy link
Member

Rubber stamp LGTM

@rvagg
Copy link
Member

I missed that 5.9 was merged, but going back through the issues I'm not seeing that we have microbenchmark results for the impact of this upgrade. Has anyone done this?

@rvagg
Copy link
Member

@nodejs/v8 ^^ re benchmarks. I know we have https://benchmarking.nodejs.org/ but has anyone run the benchmarks in source to show the difference?

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 15, 2017

@rvagg FWIW, there are rather old results in #11851

@rvagg
Copy link
Member

@vsemozhetbyt that's why I'm interested now, because those results are not promising in the whole

@targos
Copy link
MemberAuthor

targos commented Jun 19, 2017

Ping @nodejs/v8

Edit: wait, I will update to patch 37.
Edit 2: updated to 5.9.211.37

@targostargos changed the title deps: update V8 to 5.9.211.35deps: update V8 to 5.9.211.37Jun 19, 2017
@targos
Copy link
MemberAuthor

targos commented Jun 19, 2017

@targostargos mentioned this pull request Jun 19, 2017
2 tasks
@rvaggrvagg mentioned this pull request Jun 19, 2017
@targos
Copy link
MemberAuthor

Landed in 8f907b6

@targostargos closed this Jun 20, 2017
@targostargos deleted the update-v8-59 branch June 20, 2017 08:53
targos added a commit that referenced this pull request Jun 20, 2017
PR-URL: #13631 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
@refack
Copy link
Contributor

CITGM on master for good measure: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/881/

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@jasnell@rvagg@vsemozhetbyt@refack@bnoordhuis@nodejs-github-bot