doc: fix api docs style#13700
Closed
doc: fix api docs style #13700
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benjamingr approved these changes Jun 15, 2017
cjihrig approved these changes Jun 15, 2017
jasnell approved these changes Jun 15, 2017
refack approved these changes Jun 15, 2017
doc/api/fs.md Outdated
doc/api/async_hooks.md Outdated
Contributor
There was a problem hiding this comment.
Nit: I think YAML or even simply text is more correct...
ContributorAuthor
There was a problem hiding this comment.
The values in this part are separated only by a comma, but I agree on using text since it's not a data for csv/yaml. Will do! Thanks :)
lpinca approved these changes Jun 15, 2017
mhdawson approved these changes Jun 16, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: nodejs#13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ContributorAuthor
watilde commented Jun 19, 2017
ContributorAuthor
watilde commented Jun 19, 2017
Landed in 4ca3b9c. Thanks. |
watilde added a commit that referenced this pull request Jun 19, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 29, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Contributor
MylesBorins commented Aug 14, 2017
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc/api/async_hooks.md
doc/api/fs.md
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc