test: increase util.callbackify() coverage#13705
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Jun 15, 2017
tniessen approved these changes Jun 15, 2017
refack approved these changes Jun 15, 2017
refack reviewed Jun 15, 2017
Contributor
There was a problem hiding this comment.
Tiny nit: could use values.filter(v => typeof v !== 'function')
refack reviewed Jun 15, 2017
Contributor
There was a problem hiding this comment.
this output is a tiny bit unfortunate 🤷♂️ I should have covered this
benjamingr approved these changes Jun 15, 2017
refack pushed a commit to refack/node that referenced this pull request Jun 17, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: nodejs#13705
Contributor
refack commented Jun 17, 2017
Ref: #12712 |
4 tasks
BridgeAR approved these changes Jun 17, 2017
Member
There was a problem hiding this comment.
Nit: the return itself is already sufficient as the return value is implicitly wrapped in a promise. Therefore the await can be removed.
Contributor
There was a problem hiding this comment.
Indeed, but that's the way to other tests are written (e.g. https://github.com/nodejs/node/blob/master/test/parallel/test-util-callbackify.js#L31)
The rationale was to make them actually async in timing, not just in signature.
Contributor
refack commented Jun 18, 2017
@cjihrig I would like to bundle this with the other |
ContributorAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/8735/ EDIT: Linter failed, so CI again: https://ci.nodejs.org/job/node-test-pull-request/8740/ |
This commit adds coverage for util.callbackify() type checking. PR-URL: nodejs#13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: #13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: #13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: #13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 29, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: #13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: #13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
This commit adds coverage for util.callbackify() type checking. PR-URL: #13705 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Contributor
MylesBorins commented Aug 14, 2017
setting as don't land, will likely need to be revisited if we decide to backport |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds coverage for
util.callbackify()type checking.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test