tools,test: var to const

[BridgeAR]

As far as I know using const is preferable in almost all situations, so this converts probably all var declarations to const, if possible.

If this is not what you want, I'm happy to close this again or split into smaller parts.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

tools,test

[mscdex]

Even though we're TurboFan by default now, I would still be cautious about permanent deopts when using const/let. You might want to at least run a make test-check-deopts | grep -ivP ' <(?:\/|SharedFunctionInfo)' and see what aborted/disabled optimizations shows up. Some are expected though, such as the deopts in domain and vm.

[BridgeAR]

@mscdex I did that and there was no new constant deopt.

[mscdex]

Actually I just checked current master and it looks like make test-check-deopts is broken again :-(

Typically you will see a lot of output with that command I gave, because tests tend to have a lot of deopts (although the grep ignores the content of those deopt messages it still prints the filenames).

EDIT: It looks like I was mistaken. I'm guessing I just haven't ran that since the switch to V8 5.9 and TurboFan by default. There's only about 6 perm deopts as of this writing and I believe they're all inside the tests themselves.

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/8704/

[joaocgreis]

@refack If I'm not missing anything, this only influences make doc and and the licence displayed by the MSI (since common and eslint run in CI). https://nodejs.org/download/nightly/v9.0.0-nightly20170703fe730d34ce/ already has this change, the docs folder and the MSI seem to have been correctly generated.

[refack]

@refack If I'm not missing anything, this only influences make doc and and the licence displayed by the MSI (since common and eslint run in CI). https://nodejs.org/download/nightly/v9.0.0-nightly20170703fe730d34ce/ already has this change, the docs folder and the MSI seem to have been correctly generated.

Thanks!