build,win: skip vcvarsall if already set#13806
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build ContributorAuthor
refack commented Jun 20, 2017
/cc @nodejs/platform-windows @nodejs/build |
vcbuild.bat Outdated
Member
There was a problem hiding this comment.
The earlier similar line for 2017 doesn't prefix the goto target with a colon. Please can you make these consistent?
refackforce-pushed the vcbuild-idempotency-for-vs2015 branch from e189614 to 514654aCompare
richardlau approved these changes Jun 20, 2017
kunalspathak approved these changes Jun 20, 2017
tniessen approved these changes Jun 20, 2017
jasnell approved these changes Jun 20, 2017
PR-URL: nodejs#13806Fixes: nodejs#13765 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
refackforce-pushed the vcbuild-idempotency-for-vs2015 branch from 514654a to 8206a01Compareaddaleax pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #13806Fixes: #13765 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #13806Fixes: #13765 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #13806Fixes: #13765 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Aug 16, 2017
Should this be backported to |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13765
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build