doc: fix some broken references#13811
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vsemozhetbyt approved these changes Jun 20, 2017
cjihrig approved these changes Jun 20, 2017
jasnell approved these changes Jun 20, 2017
Contributor
JacksonTian commented Jun 20, 2017
LGTM |
lpinca approved these changes Jun 20, 2017
JacksonTian approved these changes Jun 20, 2017
mhdawson approved these changes Jun 20, 2017
Member
tniessen commented Jul 2, 2017
Landed in ea927b3. Thank you! 🎉 |
tniessen pushed a commit that referenced this pull request Jul 2, 2017
PR-URL: #13811 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
PR-URL: nodejs#13811 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #13811 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #13811 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #13811 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Contributor
MylesBorins commented Aug 15, 2017
I've opted not to backport this to v6.x because it includes references to apis that have not landed in that branch. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc