test: refactor test-stream2-writable#13823
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Use common.mustCall() to confirm that _write() is called only once. * Check that _write() is called with the correct argument
Trott added stream 
gibfahn approved these changes Jun 20, 2017
addaleax approved these changes Jun 20, 2017
cjihrig approved these changes Jun 20, 2017
lpinca approved these changes Jun 20, 2017
MemberAuthor
Trott commented Jun 23, 2017
refack approved these changes Jun 23, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2017
* Use common.mustCall() to confirm that _write() is called only once. * Check that _write() is called with the correct argument PR-URL: nodejs#13823 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MemberAuthor
Trott commented Jun 23, 2017
Landed in f833e25 |
Merged
addaleax pushed a commit that referenced this pull request Jun 24, 2017
* Use common.mustCall() to confirm that _write() is called only once. * Check that _write() is called with the correct argument PR-URL: #13823 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test stream