test: remove require('buffer') on 6 test files#13845
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js Refs: nodejs#13836
addaleax approved these changes Jun 21, 2017
vsemozhetbyt approved these changes Jun 21, 2017
Contributor
vsemozhetbyt commented Jun 21, 2017
cjihrig approved these changes Jun 21, 2017
aqrln approved these changes Jun 21, 2017
benjamingr approved these changes Jun 21, 2017
Member
benjamingr left a comment
benjamingr left a comment There was a problem hiding this comment.
Nice work. Please feel free to also give us any feedback about the onboarding process today.
#goodnessSquad
lpinca approved these changes Jun 21, 2017
jasnell approved these changes Jun 22, 2017
tniessen approved these changes Jun 22, 2017
mhdawson approved these changes Jun 23, 2017
tniessen pushed a commit that referenced this pull request Jun 23, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Member
tniessen commented Jun 23, 2017
Landed in d31fe53, thank you for your contribution! 🎉 CI on master after merging: https://ci.nodejs.org/job/node-test-commit-linuxone/6850/ |
addaleax pushed a commit that referenced this pull request Jun 24, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jun 29, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
* test/parallel/test-fs-mkdtemp.js * test/parallel/test-fs-read-zero-length.js * test/parallel/test-fs-read.js * test/parallel/test-fs-whatwg-url.js * test/parallel/test-fs-write-string-coerce.js * test/parallel/test-fs-write.js PR-URL: #13845 Refs: #13836 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
This was referenced Sep 5, 2017
This was referenced Sep 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #13836
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, buffer