Skip to content

test: remove unnecessary import#13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OriLev wants to merge 1 commit into from
Closed

test: remove unnecessary import #13855

OriLev wants to merge 1 commit into from

Conversation

@OriLev
Copy link
Contributor

@OriLevOriLev commented Jun 21, 2017

#goodnessSquad

This is my first node contribution

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2017
eugeneo
eugeneo reviewed Jun 21, 2017
View reviewed changes
test/parallel/test-buffer-alloc.js
constbuffer=require('buffer');
constBuffer=buffer.Buffer;
constSlowBuffer=buffer.SlowBuffer;
constSlowBuffer=require('buffer').SlowBuffer;
Copy link
Contributor

@eugeneoeugeneoJun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const{SlowBuffer } = require('buffer') can also be used.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8784/

@mscdexmscdex added the buffer Issues and PRs related to the buffer subsystem. label Jun 21, 2017
@refackrefack mentioned this pull request Jun 21, 2017
Closed
@benjamingrbenjamingr mentioned this pull request Jun 22, 2017
Closed
aqrln pushed a commit to aqrln/node that referenced this pull request Jun 24, 2017
@OriLev@aqrln
test: remove require('buffer') from 4 buffer tests
22ccbe6
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: nodejs#13836 PR-URL: nodejs#13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
@aqrln
Copy link
Contributor

aqrln commented Jun 24, 2017

Landed in 22ccbe6. Thanks for your contribution!

@aqrlnaqrln closed this Jun 24, 2017
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@OriLev@addaleax
test: remove require('buffer') from 4 buffer tests
9b7c639
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
@addaleaxaddaleax mentioned this pull request Jun 24, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@OriLev@addaleax
test: remove require('buffer') from 4 buffer tests
2e8dfc8
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@OriLev@addaleax
test: remove require('buffer') from 4 buffer tests
352e2de
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@OriLev@addaleax
test: remove require('buffer') from 4 buffer tests
c3c6699
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@OriLev@MylesBorins
test: remove require('buffer') from 4 buffer tests
611ae1e
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@OriLev@MylesBorins
test: remove require('buffer') from 4 buffer tests
4449faa
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@OriLev@MylesBorins
test: remove require('buffer') from 4 buffer tests
6d02bf4
Remove superfluous import from: * test/parallel/test-buffer-alloc.js * test/parallel/test-buffer-arraybuffer.js * test/parallel/test-buffer-badhex.js * test/parallel/test-buffer-bytelength.js Refs: #13836 PR-URL: #13855 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

+3 more reviewers

@eugeneoeugeneoeugeneo left review comments

@aqrlnaqrlnaqrln approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@OriLev@vsemozhetbyt@aqrln@eugeneo@jasnell@lpinca@cjihrig@mscdex@MylesBorins@nodejs-github-bot