test: refactor test-tls-two-cas-one-string#13896
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* order require() statements per test writing guide * add keydir variable to make readFileSync() calls more readable * make `next` argument to test() optional * use common.mustCall() to guarantee second test runs
Trott added test 
cjihrig approved these changes Jun 24, 2017
lpinca approved these changes Jun 24, 2017
MemberAuthor
Trott commented Jun 24, 2017
danbev approved these changes Jun 25, 2017
Contributor
danbev left a comment
danbev left a comment There was a problem hiding this comment.
Nit: Should a test description be added perhaps?
jasnell approved these changes Jun 26, 2017
hiroppy approved these changes Jun 26, 2017
MemberAuthor
Trott commented Jun 29, 2017
Landed in 6294791 |
Trott added a commit to Trott/io.js that referenced this pull request Jun 29, 2017
* order require() statements per test writing guide * add keydir variable to make readFileSync() calls more readable * make `next` argument to test() optional * use common.mustCall() to guarantee second test runs PR-URL: nodejs#13896 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
* order require() statements per test writing guide * add keydir variable to make readFileSync() calls more readable * make `next` argument to test() optional * use common.mustCall() to guarantee second test runs PR-URL: #13896 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
* order require() statements per test writing guide * add keydir variable to make readFileSync() calls more readable * make `next` argument to test() optional * use common.mustCall() to guarantee second test runs PR-URL: #13896 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
* order require() statements per test writing guide * add keydir variable to make readFileSync() calls more readable * make `next` argument to test() optional * use common.mustCall() to guarantee second test runs PR-URL: #13896 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Contributor
MylesBorins commented Aug 14, 2017
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextargument to test() optionalChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test tls