test: refactor test-cluster-basic#13905
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide.
Trott added cluster 
MemberAuthor
Trott commented Jun 25, 2017
cjihrig approved these changes Jun 25, 2017
lpinca approved these changes Jun 25, 2017
hiroppy approved these changes Jun 26, 2017
jasnell approved these changes Jun 26, 2017
MemberAuthor
Trott commented Jun 29, 2017
Landed in 3b727aa |
Trott added a commit to Trott/io.js that referenced this pull request Jun 29, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: nodejs#13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: #13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: #13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: #13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: #13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: #13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
* Use common.mustNotCall() to check that callback is not invoked. * Add space per test writing guide. PR-URL: #13905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster