test: remove undef NDEBUG from at-exit addons test#13998
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency.
nodejs-github-bot added addons 
ContributorAuthor
danbev commented Jun 30, 2017
bnoordhuis approved these changes Jun 30, 2017
cjihrig approved these changes Jun 30, 2017
jasnell approved these changes Jun 30, 2017
danbev added a commit to danbev/node that referenced this pull request Jul 2, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: nodejs#13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
danbev commented Jul 2, 2017
Landed in 0d95a0b |
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: nodejs#13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: #13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: #13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: #13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: #13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
The at-exit addons test uses asserts like the other addons tests, but at-exit is the only one that undefines NDEBUG to make sure that asserts are enabled. This commit removes the undef for consistency. PR-URL: #13998 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The at-exit addons test uses asserts like the other addons tests,
but at-exit is the only one that undefines NDEBUG to make sure
that asserts are enabled. This commit removes the undef for
consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test