test: use a different external object in test-util-inspect#14003
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test/parallel/test-util-inspect.js Outdated
Member
There was a problem hiding this comment.
Destructuring can be used here, and generally these imports are positioned at the top of the file.
TimothyGu approved these changes Jun 30, 2017
lpinca approved these changes Jun 30, 2017
hiroppy approved these changes Jul 3, 2017
Member
jasnell commented Jul 10, 2017
refack suggested changes Jul 10, 2017
Contributor
refack left a comment
refack left a comment There was a problem hiding this comment.
IMHO even require surrogates should be at the top of the file.
ContributorAuthor
psmarshall commented Jul 24, 2017
Sorry for the slow turnaround, I've moved the import to the top. |
refack approved these changes Jul 24, 2017
Contributor
@psmarshall thank you! |
refack pushed a commit that referenced this pull request Jul 24, 2017
PR-URL: #14003 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Contributor
Landed in fe14f9b @psmarshall congratulations on GitHub promoting you from: |
addaleax pushed a commit that referenced this pull request Jul 24, 2017
PR-URL: #14003 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
This test can fail if process.stdin._handle doesn't exist, which can happen in some environments. The test just wants to check that external objects are represented properly, so we can pass in a JSStream external object instead.