test: skip test-fs-readdir-ucs2 if no support#14029
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Jul 1, 2017
MemberAuthor
Trott commented Jul 1, 2017
MemberAuthor
Trott commented Jul 1, 2017
Looks like it's working now. Removing the |
lpinca approved these changes Jul 1, 2017
Member
There was a problem hiding this comment.
Is e.code set? If so it might be better to test against it rather than the message.
MemberAuthor
Trott commented Jul 1, 2017
refack approved these changes Jul 1, 2017
richardlau approved these changes Jul 2, 2017
3 tasks
If the filesystem does not support UCS2, do not run the test. Fixes: nodejs#14028
MemberAuthor
Trott commented Jul 3, 2017
refack pushed a commit to refack/node that referenced this pull request Jul 4, 2017
If the filesystem does not support UCS2, do not run the test. PR-URL: nodejs#14029Fixes: nodejs#14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Contributor
Landed in 4dd7d09 Extra CI for sanity of |
Contributor
refack commented Jul 4, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
If the filesystem does not support UCS2, do not run the test. PR-URL: #14029Fixes: #14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
If the filesystem does not support UCS2, do not run the test. PR-URL: #14029Fixes: #14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
If the filesystem does not support UCS2, do not run the test. PR-URL: #14029Fixes: #14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
If the filesystem does not support UCS2, do not run the test. PR-URL: #14029Fixes: #14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Aug 15, 2017
If the filesystem does not support UCS2, do not run the test. PR-URL: nodejs#14029Fixes: nodejs#14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
If the filesystem does not support UCS2, do not run the test. Backport-PR-URL: #14835 PR-URL: #14029Fixes: #14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
If the filesystem does not support UCS2, do not run the test. Backport-PR-URL: #14835 PR-URL: #14029Fixes: #14028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the filesystem does not support UCS2, do not run the test.
Fixes: #14028
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs