tools: update eslint-plugin-markdown up to 1.0.0-beta.7#14047
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
An issue affecting Node.js source has been fixed in eslint-plugin-markdown so we don't need to pin it to beta-4 anymore. Refs: eslint/markdown#69
ContributorAuthor
vsemozhetbyt commented Jul 3, 2017
2 tasks
vsemozhetbyt commented Jul 3, 2017
| {type:'CNAME', value:'example.com' }, | ||
| {type:'MX', exchange:'alt4.aspmx.l.example.com', priority:50 }, | ||
| {type:'NS', value:'ns1.example.com', type:'NS' }, | ||
| {type:'NS', value:'ns1.example.com' }, |
ContributorAuthor
There was a problem hiding this comment.
This fix illustrates why we should use rule-disabling instead of full disabling when it is possible.
ContributorAuthor
vsemozhetbyt commented Jul 3, 2017
All commits should be squashed before landing as they are not self-sufficient (the second fails linting without the third) and are separated for easier reviewing. |
Trott approved these changes Jul 3, 2017
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
Assuming a clean lint run on CI: First and last commits LGTM. Middle commit rubber-stamp LGTM.
refack approved these changes Jul 3, 2017
cjihrig approved these changes Jul 3, 2017
This was referenced Jul 3, 2017
ContributorAuthor
vsemozhetbyt commented Jul 4, 2017
There is an issue in Our code is unaffected (we always have an empty line before such comments), but we should better track the fixing and update to reduce possible confusing. |
ContributorAuthor
vsemozhetbyt commented Jul 5, 2017
Landed in 15599cb |
ContributorAuthor
@nodejs/collaborators You may need to rebase your open doc PRs with code fragments after this and rerun Linter CI. |
addaleax pushed a commit that referenced this pull request Jul 11, 2017
* Remove pinning of eslint-plugin-markdown An issue affecting Node.js source has been fixed in eslint-plugin-markdown so we don't need to pin it to beta-4 anymore. Refs: eslint/markdown#69 * Update eslint-plugin-markdown up to 1.0.0-beta.7 * Fix docs for [email protected] PR-URL: #14047 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
* Remove pinning of eslint-plugin-markdown An issue affecting Node.js source has been fixed in eslint-plugin-markdown so we don't need to pin it to beta-4 anymore. Refs: eslint/markdown#69 * Update eslint-plugin-markdown up to 1.0.0-beta.7 * Fix docs for [email protected] PR-URL: #14047 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
* Remove pinning of eslint-plugin-markdown An issue affecting Node.js source has been fixed in eslint-plugin-markdown so we don't need to pin it to beta-4 anymore. Refs: eslint/markdown#69 * Update eslint-plugin-markdown up to 1.0.0-beta.7 * Fix docs for [email protected] PR-URL: #14047 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
* Install [email protected] * Add doc/.eslintrc.yaml * Add `plugins: [markdown]` to the main .eslintrc.yaml * .js files in doc folder added to .eslintignore * Update Makefile, vcbuild.bat, and tools/jslint.js Refs: #12563 Refs: #12640 Refs: #14047 PR-URL: #14067 Reviewed-By: James Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
* Install [email protected] * Add doc/.eslintrc.yaml * Add `plugins: [markdown]` to the main .eslintrc.yaml * .js files in doc folder added to .eslintignore * Update Makefile, vcbuild.bat, and tools/jslint.js Refs: #12563 Refs: #12640 Refs: #14047 PR-URL: #14067 Reviewed-By: James Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 31, 2017
* Install [email protected] * Add doc/.eslintrc.yaml * Add `plugins: [markdown]` to the main .eslintrc.yaml * .js files in doc folder added to .eslintignore * Update Makefile, vcbuild.bat, and tools/jslint.js Refs: #12563 Refs: #12640 Refs: #14047 PR-URL: #14067 Reviewed-By: James Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools, doc
Commit 1:
Commit 2:
Commit 3:
Refs:
eslint/markdown#69
eslint/markdown#73
https://github.com/eslint/eslint-plugin-markdown#skipping-blocks
#14045