test: ignore connection errors for hostname check#14073
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Jul 4, 2017
ContributorAuthor
refack commented Jul 4, 2017
I've become so dependent on my IDE, every time I try the GitHub GUI, major failage: |
lpinca approved these changes Jul 5, 2017
Member
Trott commented Jul 5, 2017
I'm totally neutral on this change. No objection. Feel free to land if Ci is green and no one objects after the 48 hours are up. I'm only commenting because I got @-mentioned. :-D |
PR-URL: nodejs#14073 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refackforce-pushed the i-dont-care-i-love-it branch from 96e0c5c to 4d7946aCompareaddaleax pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #14073 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #14073 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #14073 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #14065
Be more explicit about why we don't care about errors
/cc @Trott @nodejs/testing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test