cctest: Fix cctest failure on windows#14111
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows.
nodejs-github-bot added dont-land-on-v4.x inspector ContributorAuthor
MSLaguana commented Jul 6, 2017
@eugeneo Can you take a look please? |
refack approved these changes Jul 6, 2017
Contributor
refack commented Jul 6, 2017
/cc @nodejs/build Ref: nodejs/build#769 CI is false Green |
Contributor
refack commented Jul 6, 2017
eugeneo approved these changes Jul 6, 2017
Contributor
eugeneo left a comment
eugeneo left a comment There was a problem hiding this comment.
LGTM if it passes CI on all platforms.
cjihrig approved these changes Jul 6, 2017
mscdex added c++ 
kfarnung approved these changes Jul 6, 2017
Contributor
refack commented Jul 6, 2017
@Trott look it's green, not yellow. 🌞 🍹 |
2 tasks
Contributor
refack commented Jul 7, 2017
@joyeecheung does this work for you (before and/or after)? |
Contributor
refack commented Jul 7, 2017
Goal achieved ✔️ |
kunalspathak approved these changes Jul 7, 2017
joaocgreis approved these changes Jul 9, 2017
Member
joaocgreis left a comment
joaocgreis left a comment There was a problem hiding this comment.
Rubber-stamp LGTM. I will add cctest.tap to the list of tap files in CI when this lands.
Member
kunalspathak commented Jul 9, 2017
@joaocgreis , I made minor changes in CI job for |
jasnell approved these changes Jul 10, 2017
refack pushed a commit to refack/node that referenced this pull request Jul 10, 2017
Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows. PR-URL: nodejs#14111 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
refack commented Jul 10, 2017
Landed in 94dd425 |
addaleax pushed a commit that referenced this pull request Jul 11, 2017
Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows. PR-URL: #14111 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows. PR-URL: #14111 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows. PR-URL: #14111 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: James M Snell <[email protected]>
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux converts the ipv6 address "::" to "::1", while windows does not.
By explicitly using "::1" in the test we allow it to succeed on windows.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
cctest