tools: update outdated package.json engine field#14165
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added doc 
lpinca left a comment
lpinca left a comment There was a problem hiding this comment.
I guess it is technically true but so outdated that it is no longer relevant.
refack commented Jul 11, 2017
Is it worth updating? (I'm deducing latest active version is https://github.com/AlastairTaft/node-doc-generator) |
Nope, it uses @refack it looks to me like that's an extraction of what's in-tree here right? Not sure what you're thinking should happen here |
refack commented Jul 11, 2017
I assumed the dependency was reversed (that https://github.com/AlastairTaft/node-doc-generator was more updated), so NM. |
gibfahn commented Jul 11, 2017
Then shouldn't it be |
strugee commented Jul 11, 2017
I guess? I mean, I didn't spend a lot of time looking for other ES6 features so I don't actually know. If #14164 lands it will require |
I'd rather keep it if there's a chance that it might save someone some confusion at some point. Maybe set it to EDIT: Or just make it |
strugee commented Jul 12, 2017
@gibfahn I added a new commit changing it to |
gibfahn left a comment
gibfahn left a comment There was a problem hiding this comment.
LGTM (it can be squashed by you or on landing, either is fine).
strugee changed the title engine fieldengine field
PR-URL: #14165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell commented Jul 14, 2017
Landed in 49e63ff |
PR-URL: #14165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins commented Aug 16, 2017
I've backported this. let me know if it should have been |
PR-URL: #14165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14165 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
11 participants
This
enginesfield clearly hasn't been true for a long time and is just useless. So get rid of it.Checklist
Affected core subsystem(s)
tools