test: reduce run time for test-benchmark-crypto#14189
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Specify options to reduce combinations of benchmarks run during testing. This reduces the run time by approximately 30% and will hopefully allow Raspberry Pi 1 devices in CI to finish the test.
Trott added benchmark 
MemberAuthor
Trott commented Jul 12, 2017
MemberAuthor
Trott commented Jul 12, 2017
As with the other test-benchmark-* fixes, I'd like to expedite this if others agree it ought to be. |
refack approved these changes Jul 12, 2017
cjihrig approved these changes Jul 12, 2017
gibfahn approved these changes Jul 12, 2017
MemberAuthor
Trott commented Jul 12, 2017
Oof, this got the Raspberry Pi 1 green, but it took 173 seconds to run. Timeout is 180 seconds. Going to land anyway because that's better than always failing, but we'll probably have to look for further efficiencies to get this to be reliable. |
Trott added a commit to Trott/io.js that referenced this pull request Jul 12, 2017
Specify options to reduce combinations of benchmarks run during testing. This reduces the run time by approximately 30% and will hopefully allow Raspberry Pi 1 devices in CI to finish the test. PR-URL: nodejs#14189 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MemberAuthor
Trott commented Jul 12, 2017
Landed in 3eae310 |
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Specify options to reduce combinations of benchmarks run during testing. This reduces the run time by approximately 30% and will hopefully allow Raspberry Pi 1 devices in CI to finish the test. PR-URL: #14189 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
Specify options to reduce combinations of benchmarks run during testing. This reduces the run time by approximately 30% and will hopefully allow Raspberry Pi 1 devices in CI to finish the test. PR-URL: #14189 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify options to reduce combinations of benchmarks run during testing.
This reduces the run time by approximately 30% and will hopefully allow
Raspberry Pi 1 devices in CI to finish the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark crypto