Skip to content

test: change the regluar express#14266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AkiraXue wants to merge 1 commit into from
Closed

test: change the regluar express #14266

AkiraXue wants to merge 1 commit into from

Conversation

@AkiraXue
Copy link
Contributor

@AkiraXueAkiraXue commented Jul 16, 2017•
edited
Loading

update the test/parallel/test-vm-create-context-arg.js
in line 27 to change the regluar expression TypeError
with the /^TypeError: sandbox must be an object$/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@AkiraXue
Copy link
ContributorAuthor

AkiraXue commented Jul 16, 2017

change the regular expression in test/parallel/test-vm-create-context-arg.js

@AkiraXue
test: change the regluar express
f8024fb
update the test/parallel/test-vm-create-context-arg.js in line 27 to change the regluar expression `TypeError` with the `/^TypeError: sandbox must be an object$/`
@TimothyGu
Copy link
Member

TimothyGu commented Jul 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9147/

@TimothyGuTimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 16, 2017
@AkiraXue@Trott
test: use regluar expression in vm test
e8170f2
update test/parallel/test-vm-create-context-arg.js in line 27 to change `TypeError` to the regular expression with the `/^TypeError: sandbox must be an object$/`. PR-URL: nodejs#14266 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 16, 2017

Landed in e8170f2.

Thanks for the contribution! 🎉

@TrottTrott closed this Jul 16, 2017
@addaleaxaddaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@AkiraXue@addaleax
test: use regluar expression in vm test
e37510a
update test/parallel/test-vm-create-context-arg.js in line 27 to change `TypeError` to the regular expression with the `/^TypeError: sandbox must be an object$/`. PR-URL: #14266 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@AkiraXue@Fishrock123
test: use regluar expression in vm test
8756686
update test/parallel/test-vm-create-context-arg.js in line 27 to change `TypeError` to the regular expression with the `/^TypeError: sandbox must be an object$/`. PR-URL: #14266 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@AkiraXue@MylesBorins
test: use regluar expression in vm test
8c41325
update test/parallel/test-vm-create-context-arg.js in line 27 to change `TypeError` to the regular expression with the `/^TypeError: sandbox must be an object$/`. PR-URL: #14266 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@AkiraXue@MylesBorins
test: use regluar expression in vm test
a71e23a
update test/parallel/test-vm-create-context-arg.js in line 27 to change `TypeError` to the regular expression with the `/^TypeError: sandbox must be an object$/`. PR-URL: #14266 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@AkiraXue@MylesBorins
test: use regluar expression in vm test
94ff591
update test/parallel/test-vm-create-context-arg.js in line 27 to change `TypeError` to the regular expression with the `/^TypeError: sandbox must be an object$/`. PR-URL: #14266 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@gibfahngibfahngibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AkiraXue@TimothyGu@Trott@cjihrig@gibfahn@MylesBorins@nodejs-github-bot