[js-confcn]replace string concatenation with template literals#14269
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
replace the string concation at test/addons-napi/test_reference/test.js
nodejs-github-bot added node-api 
joyeecheung added the code-and-learn 
joyeecheung approved these changes Jul 16, 2017
Member
joyeecheung commented Jul 16, 2017
TimothyGu added code-and-learn replace string-concation in test/async-hooks/test-signalwrap.js with template literals
Member
targos commented Jul 16, 2017
The change in test-signalwrap is in conflict with #14295 |
4 tasks
cjihrig approved these changes Jul 16, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 16, 2017
Replace the string concat at test/addons-napi/test_reference/test.js. PR-URL: nodejs#14269 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
Trott commented Jul 16, 2017
Landed the first commit in e3f7a54. (The second commit is in a different PR and is unrelated, so I won't land it here.) Thanks for the contribution! 🎉 |
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Replace the string concat at test/addons-napi/test_reference/test.js. PR-URL: #14269 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
Replace the string concat at test/addons-napi/test_reference/test.js. PR-URL: #14269 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
Replace the string concat at test/addons-napi/test_reference/test.js. PR-URL: nodejs#14269 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Replace the string concat at test/addons-napi/test_reference/test.js. Backport-PR-URL: #19447 PR-URL: #14269 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace the string concation at test/addons-napi/test_reference/test.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)