[JSConf CN Code&Learn] test:Replace string concatenation with template literals#14279
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added async_hooks 
miccycn changed the title 
Trott added the code-and-learn 
TimothyGu added code-and-learn miccycn changed the title 
gibfahn approved these changes Jul 16, 2017
cjihrig approved these changes Jul 16, 2017
TimothyGu approved these changes Jul 16, 2017
tniessen approved these changes Jul 16, 2017
gireeshpunathil approved these changes Jul 16, 2017
Contributor
vsemozhetbyt commented Jul 16, 2017
refack approved these changes Jul 16, 2017
Member
Trott commented Jul 16, 2017
CI was green but I canceled some of the slower hosts to help with our CI backlog problem. IMO the CI for this can be treated as green. |
Member
Small change, green CI, 7 approvals, fast-tracking. Landed in fc71131 refack: fixed typo and the edit makes GitHub link to the commit |
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 17, 2017
Replace string concatenation with template literals in test/async-hooks/verify-graph.js. PR-URL: nodejs#14279 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Member
Trott commented Jul 17, 2017
Thanks for the contribution! 🎉 |
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Replace string concatenation with template literals in test/async-hooks/verify-graph.js. PR-URL: #14279 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
Replace string concatenation with template literals in test/async-hooks/verify-graph.js. PR-URL: #14279 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[JSConf CN Code&Learn]
Replace string concatenation in
test/async-hooks/verify-graph.jswith template literals.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes