doc: replace dead link in v8 module#14372
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joyeecheung approved these changes Jul 19, 2017
Member
joyeecheung left a comment
joyeecheung left a comment There was a problem hiding this comment.
LGTM as it is, using the 8.x version would be better but then the doc already says this data structure would change depending on v8 versions and there is more than one year until 6.x ends LTS.
cjihrig approved these changes Jul 19, 2017
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM, but I'd update this to the Node 8 link, and update it to the Node 6 link when it's backported.
ContributorAuthor
drboyer commented Jul 19, 2017
Thanks! I just updated the link to node-8.0 instead. Is there anything further I need to do with this? (This is my first PR to the node.js project! 🎉) |
lpinca approved these changes Jul 19, 2017
joyeecheung pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
I believe this does not need to wait for 48 hours and we already got enough approvals. Landed in 7bc666b, thanks for your contribution and welcome to Node.js! |
addaleax pushed a commit that referenced this pull request Jul 22, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Closed
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
PR-URL: #14372 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified a dead link to the V8
GetHeapSpaceStatistics()function on the v8 module documentation page. I updated the link to the version from the6.10version of the V8 docs, but could easily update it to the8.0version if desired, for some reason.Checklist
Affected core subsystem(s)
doc