http: reset stream to unconsumed in unconsume()#14410
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
cjihrig approved these changes Jul 21, 2017
Contributor
There was a problem hiding this comment.
Can you add the hasCrypto skip check.
Reset the underlying socket of an HTTP stream to be marked as unconsume after the HTTP parser no longer owns it. Fixes: nodejs#14407
addaleaxforce-pushed the http-parser-unconsume branch from 51d33dc to f9edaaeCompare
bnoordhuis approved these changes Jul 21, 2017
lpinca reviewed Jul 21, 2017
| })); | ||
| server.listen(0, common.mustCall(() =>{ | ||
| http.request({ |
Member
There was a problem hiding this comment.
Nit (feel free to ignore): http.get()? so we can remove .end().
tniessen approved these changes Jul 21, 2017
| http.get({ | ||
| port: server.address().port, | ||
| headers:{ | ||
| 'Connection': 'Upgrade', |
Member
There was a problem hiding this comment.
Nit: Even though we agreed not to lint quote-props in #14059, most people seem to prefer as-needed, so I would probably drop the quotes here. It's up to you :)
MemberAuthor
There was a problem hiding this comment.
I like the quotes for map-like objects :)
jasnell approved these changes Jul 21, 2017
lpinca approved these changes Jul 22, 2017
MemberAuthor
addaleax commented Jul 24, 2017
MemberAuthor
addaleax commented Jul 26, 2017
Landed in 29353e5 |
addaleax added a commit that referenced this pull request Jul 26, 2017
Reset the underlying socket of an HTTP stream to be marked as unconsume after the HTTP parser no longer owns it. Fixes: #14407 PR-URL: #14410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax added a commit that referenced this pull request Jul 27, 2017
Reset the underlying socket of an HTTP stream to be marked as unconsume after the HTTP parser no longer owns it. Fixes: #14407 PR-URL: #14410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Contributor
MylesBorins commented Aug 16, 2017
Should this be backported? It lands cleanly |
Contributor
MylesBorins commented Sep 19, 2017
ping @nodejs/streams |
Member
mcollina commented Sep 19, 2017
@MylesBorins 👍 for me. |
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
Reset the underlying socket of an HTTP stream to be marked as unconsume after the HTTP parser no longer owns it. Fixes: #14407 PR-URL: #14410 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the underlying socket of an HTTP stream to be marked as
unconsume after the HTTP parser no longer owns it.
Fixes: #14407
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http