V6.x backport 13531 docs#14413
Closed
V6.x backport 13531 docs #14413
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Backport of the documentation from nodejs#13531 that did not land in 2fb1381. PR-URL: nodejs#13553 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
sam-githubforce-pushed the v6.x-backport-13531-docs branch from c832efa to 3dd5282Compare
refack approved these changes Jul 21, 2017
ContributorAuthor
sam-github commented Jul 21, 2017
@MylesBorins @nodejs/lts I'm not sure what the metadata should be. I left the metadata from the original PR in the commit, but that seems weird. Have we agreed on a scheme for what metadata should look like on backport PRs? |
Contributor
MylesBorins commented Jul 21, 2017
@sam-github we agreed to keep all original meta data (including reviews) and add a new field |
Contributor
MylesBorins commented Jul 21, 2017
I've gone ahead and rebased this back into the original cherry-pick 59eb761 |
gibfahn approved these changes Jul 22, 2017
Member
gibfahn commented Jul 22, 2017
My bad @MylesBorins, didn't realise you meant you'd rebased and landed on v6.x-staging. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of docs from #13531
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc