tools: update to ESLint 4.3.0#14417
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ESLint 4.3.0 flags an extra indentation issue that affects two of our destructuring assignments in `lib`. This is a whitespace-only update to comply prior to updating.
Trott added lib / src 
nodejs-github-bot added the lib / src 
jasnell approved these changes Jul 21, 2017
cjihrig approved these changes Jul 21, 2017
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
Rubberstamp LGTM to the upgrade. Actual LGTM to the other commit.
not-an-aardvark approved these changes Jul 21, 2017
silverwind approved these changes Jul 22, 2017
refack approved these changes Jul 24, 2017
| # MemberExpression: off, | ||
| # ObjectExpression: first, | ||
| # SwitchCase: 1}] | ||
| #CallExpression:{arguments: first}, |
Contributor
There was a problem hiding this comment.
This will conflict with #14403.
IMHO both seem appropriate for this change...
MemberAuthor
There was a problem hiding this comment.
No conflict with git am -3 because they're both the exact same change. :-D
MemberAuthor
Trott commented Jul 24, 2017
MemberAuthor
Trott commented Jul 25, 2017
Jenkins had to be restarted so previous CI results are lost. Running CI again. |
MemberAuthor
Trott commented Jul 25, 2017
Trott added a commit that referenced this pull request Jul 25, 2017
ESLint 4.3.0 flags an extra indentation issue that affects two of our destructuring assignments in `lib`. This is a whitespace-only update to comply prior to updating. PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Trott added a commit that referenced this pull request Jul 25, 2017
PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 27, 2017
ESLint 4.3.0 flags an extra indentation issue that affects two of our destructuring assignments in `lib`. This is a whitespace-only update to comply prior to updating. PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 27, 2017
PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
7 tasks
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
PR-URL: #14417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit:
Second commit:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools lib