Skip to content

test: refactor test-benchmark-timers#14464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

test: refactor test-benchmark-timers #14464

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jul 24, 2017

  • add type option to reduce combinations of benchmarks run (saves
    about 15% on run duration of test on my local machine)
  • alphabetize options
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark timers

@Trott
test: refactor test-benchmark-timers
0d17cb3
* add `type` option to reduce combinations of benchmarks run (saves about 15% on run duration of test on my local machine) * alphabetize options
@TrottTrott added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jul 24, 2017
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 24, 2017
@Trott
Copy link
MemberAuthor

Trott commented Jul 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9358/

Trott added a commit to Trott/io.js that referenced this pull request Jul 27, 2017
@Trott
test: refactor test-benchmark-timers
d3e07e3
* add `type` option to reduce combinations of benchmarks run (saves about 15% on run duration of test on my local machine) * alphabetize options PR-URL: nodejs#14464 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Jul 27, 2017

Landed in d3e07e3

@TrottTrott closed this Jul 27, 2017
addaleax pushed a commit that referenced this pull request Jul 27, 2017
@Trott@addaleax
test: refactor test-benchmark-timers
91b6ba1
* add `type` option to reduce combinations of benchmarks run (saves about 15% on run duration of test on my local machine) * alphabetize options PR-URL: #14464 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
@addaleaxaddaleax mentioned this pull request Aug 2, 2017
Merged
@TrottTrott deleted the bench-time-opt branch January 13, 2022 22:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@Fishrock123Fishrock123Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.testIssues and PRs related to the tests.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@jasnell@Fishrock123@cjihrig@MylesBorins@nodejs-github-bot