(v6.x backport) process: add --redirect-warnings command line argument#14480
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
ContributorAuthor
sam-github commented Jul 25, 2017
Parking this until the next semver minor release of 6.x, see #14418 (comment) @nodejs/lts |
sam-github added lts-watch-v6.x semver-minor 
MylesBorinsforce-pushed the v6.x-staging branch 6 times, most recently from f9419c2 to 403c465Compare
MylesBorinsforce-pushed the v6.x-staging branch 2 times, most recently from aaf4e13 to 31f572cCompare
Contributor
MylesBorins commented Sep 19, 2017
Needs a rebase. Good to land |
sam-githubforce-pushed the v6.x-backport-redirect-warnings branch 2 times, most recently from f6063fc to 33c45ceCompareContributorAuthor
sam-github commented Sep 20, 2017
Landed in adf6d16 |
Contributor
MylesBorins commented Sep 20, 2017
backing this out of v6.x-staging it is not ready to land yet. We will land the minors next month when we are prepping the minor release |
sam-githubforce-pushed the v6.x-backport-redirect-warnings branch from 33c45ce to a76b3b8Compare4 tasks
MylesBorinsforce-pushed the v6.x-staging branch from b811464 to 2c8fe97CompareContributor
MylesBorins commented Oct 10, 2017
landed in 158906b707 |
Contributor
MylesBorins commented Oct 10, 2017
@sam-github I had to back this out as it was breaking the build. Can you please rebase and confirm that this compiles |
MylesBorinsforce-pushed the v6.x-staging branch from 355249a to 0597d3fComparesam-githubforce-pushed the v6.x-backport-redirect-warnings branch 2 times, most recently from b879e03 to 2604584CompareContributorAuthor
sam-github commented Oct 10, 2017
rebased again, and it compiles for me, I'm running tests locally and on ci: https://ci.nodejs.org/job/node-test-pull-request/10590/ |
ContributorAuthor
sam-github commented Oct 10, 2017
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. PR-URL: nodejs#10116 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Mutations of the environment can invalidate pointers to environment variables, so make `secure_getenv()` copy them out instead of returning pointers. This is the part of nodejs#11051 that applies to nodejs@03e89b3
sam-githubforce-pushed the v6.x-backport-redirect-warnings branch from 2604584 to 63c1ce4CompareContributorAuthor
sam-github commented Oct 10, 2017
replaced by #12677 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.
Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.
If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.
If the file already exists, it will be appended to.
PR-URL: #10116
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Michal Zasso [email protected]
Reviewed-By: Fedor Indutny [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)