Skip to content

Conversation

@TimothyGu
Copy link
Member

@TimothyGuTimothyGu commented Jul 30, 2017

Fixes: #11103

Checklist
Affected core subsystem(s)

doc, url

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jul 30, 2017
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this oversight!

@TimothyGu
Copy link
MemberAuthor

Landed in 6e79076. Thanks to all!

@TimothyGuTimothyGu deleted the url-format-changelog branch August 1, 2017 03:47
TimothyGu added a commit that referenced this pull request Aug 1, 2017
PR-URL: #14543Fixes: #11103 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 1, 2017
PR-URL: #14543Fixes: #11103 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@addaleaxaddaleax mentioned this pull request Aug 2, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v7.x undocumented backward incompatibility of url.format()

9 participants

@TimothyGu@refack@jasnell@Trott@addaleax@lpinca@cjihrig@tniessen@nodejs-github-bot