[v8.x] zlib: fix interaction of flushing and needDrain#14571
Closed
+96 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes: nodejs#14523 PR-URL: nodejs#14527 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
addaleax commented Aug 1, 2017
jasnell approved these changes Aug 1, 2017
addaleax added a commit that referenced this pull request Aug 2, 2017
Backport-PR-URL: #14571 Backport-Reviewed-By: James M Snell <[email protected]> Fixes: #14523 PR-URL: #14527 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
addaleax commented Aug 2, 2017
Landed in e529914 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14523
Backport of: #14527
The conflicts were only in zlib.js.