doc: add name to readme#14692
Closed
doc: add name to readme #14692
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott approved these changes Aug 8, 2017
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
LGTM. Commit title might be better as doc: add gabrielschulhof to collaborators but either way.
ContributorAuthor
gabrielschulhof commented Aug 8, 2017
gabrielschulhofforce-pushed the add-to-readme branch from e79c419 to 8d5bd23Compare
cjihrig approved these changes Aug 8, 2017
ContributorAuthor
gabrielschulhof commented Aug 8, 2017
Member
benjamingr commented Aug 8, 2017
Welcome aboard!!! |
benjamingr approved these changes Aug 8, 2017
gabrielschulhof pushed a commit that referenced this pull request Aug 8, 2017
PR-URL: #14692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
benjamingr commented Aug 8, 2017
If you feel like it - you live near @petkaantonov maybe meet up? |
ContributorAuthor
gabrielschulhof commented Aug 8, 2017
Thanks all! |
ContributorAuthor
gabrielschulhof commented Aug 8, 2017
Landed in 24c4505 |
Merged
Trott added the notable-change addaleax pushed a commit that referenced this pull request Aug 9, 2017
PR-URL: #14692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
PR-URL: #14692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
PR-URL: #14692 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding my name to README.md
Checklist
Affected core subsystem(s)
doc