gitignore: ignore .DS_Store for macOS

[kfarnung]

Porting upstream from nodejs/node-chakracore#363 on behalf of @tommyZZM.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

gitignore

[Fishrock123]

@tommyZZM Please add .DS_Store to your global gitignore. It belongs there rather than per project.

[Fishrock123]

I'm not sure why it didn't ignore properly, but we already ignore all dotfiles and whitelist the ones we need. Check the top of the file.

(This change in and of itself should not land.)

[Fishrock123]

(Aside: duplicate of various past issues pre-whitelist: https://github.com/nodejs/node/pulls?q=is%3Apr+ds_store+is%3Aclosed)

[Fishrock123]

Also, summoning @claudiorodriguez who wrote that patch: 15cc7c0

[refack]

@tommyZZM did you by any chance run git add . -A -f at some point?

[kfarnung]

Thanks @Fishrock123, it does seem like that should cover it, I'll ping @tommyZZM and try to get more information.

[kfarnung]

I see the issue now, the .DS_Store files are in the deps folder (from @tommyZZM in nodejs/node-chakracore#363):

node-chakracore$ git status On branch master Your branch is up-to-date with 'origin/master'. Untracked files: (use "git add <file>..." to include in what will be committed .DS_Store chakrashim/.DS_Store npm/.DS_Store openssl/.DS_Store openssl/openssl/.DS_Store v8/.DS_Store v8/test/.DS_Store v8/test/mjsunit/.DS_Store ../tools/eslint/.DS_Store ../tools/eslint/node_modules/.DS_Store

Which makes sense given the commit that @Fishrock123 referenced, it explicitly allows all dotfiles in the deps directories:

!deps/**/.* 

I'm personally not opposed to this change if it simplifies life for potential contributors, but as it stands this appears to be the intended behavior.

[kfarnung]

Looks like GitHub has a repo for that: https://github.com/github/gitignore/blob/master/Global/macOS.gitignore

[Fishrock123]

Ah, right. Ordinarily those folders do not need to be touched, so this isn't usually an issue.

I suggest making a refined whitelist for the chakrashim parts specifically and ignoring everything else. The other folders I think it is best to leave up to the end user, lest we repeat the never-ending-meta-file-ignoring again.

[kfarnung]

I'm starting to think that having a global .gitignore is the correct solution. Even refining using /deps/chakrashim/.gitignore wouldn't really help @tommyZZM since the files also show up under v8 and openssl.

[Fishrock123]

IMO, if you edit the deps directly this is kinda on you.

[kfarnung]

I think the consensus was not to land this change, so let's just close the PR.

[tommyZZM]

hi @Fishrock123@kfarnung

i have added .DS_Store to .gitignore_global with git config --global core.excludesfile

.gitignore_global

.DS_Store *.DS_Store **/.DS_Store 

it works fine in other remotes , but not working in node and node-chakracore

my git version is 2.8.1, i tried update to 2.14.1, but still not get rid of .DS_Store

i found these rules may be the reason cause some .DS_Store not ignored

.gitignore

 # Whitelist dotfiles .* -!deps/**/.* -!test/fixtures/**/.* -!tools/eslint/**/.* -!tools/doc/node_modules/**/.* +#!deps/**/.* +#!test/fixtures/**/.* +#!tools/eslint/**/.* +#!tools/doc/node_modules/**/.* 

i commented these lines and .DS_Stores are gone

then i tired may the most simplest modification is just add .DS_Store to .gitignore directly

.gitignore

+.DS_Store 

and it works

---

JUST UPDATED

i found a solution without remove or add anything

the sequence of rules in #Whitelist dotfiles causes the problem 😄

.gitignore

# Whitelist dotfiles -.* !deps/**/.* !test/fixtures/**/.* !tools/eslint/**/.* !tools/doc/node_modules/**/.* !.editorconfig !.eslintignore !.eslintrc.yaml !.gitattributes !.github !.gitignore !.gitkeep !.mailmap !.remarkrc +.* 

move the .* to bottom solve the problem!

[tommyZZM]

hi @Fishrock123@kfarnung

But modify sequence of rules will causes more problem

This overrides all the preceding rules. Previously, adding .foo to the test/fixtures directory would be reported by git, which is what we want. With this change, it will be ignored.

add .DS_Store at bottom may be better

# Whitelist dotfiles .* !deps/**/.* !test/fixtures/**/.* !tools/eslint/**/.* !tools/doc/node_modules/**/.* !.editorconfig !.eslintignore !.eslintrc.yaml !.gitattributes !.github !.gitignore !.gitkeep !.mailmap !.remarkrc +.DS_Store 

my current macOS(10.12.6) will auto generate .DS_Store without actually opening the folder. so this problem nervers me ...

i do not thing besides git clone the remote ,and then after some times reading code, git status will show this untracked changes of .DS_Stores

[gibfahn]

Yeah okay, this happens for me as well if I open up Finder and click around the deps/ subdirectories. I guess I've never done that before so didn't notice.

I suggest making a refined whitelist for the chakrashim parts specifically and ignoring everything else. The other folders I think it is best to leave up to the end user, lest we repeat the never-ending-meta-file-ignoring again.

I think @Fishrock123 's suggestion makes most sense. Ignore all dotfiles in deps/ except for a whitelist. Or if that's not feasible we could take the nuclear option of ignoring deps/ completely, and requiring people updating deps to use git add -f deps/.

@tommyZZM interesting that .DS_Store files get generated without you going into the folder, I'm on 10.12.6 as well, and I don't see that. Maybe your IDE is navigating into those folders or something.

[tommyZZM]

@gibfahn maybe some solfware (VisualStudioCore、SourceTree) make them get generated

[refack]

Y'all know about .git/info/exclude

[gibfahn]

Y'all know about .git/info/exclude

Doesn't local .gitignore take precedence over it? See docs: https://git-scm.com/docs/gitignore#_description

[refack]

Doesn't local .gitignore take precedence over it? See docs: https://git-scm.com/docs/gitignore#_description

Boop, read it upside down

[xgqfrms-GitHub]

.gitignore & .DS_Store

https://stackoverflow.com/questions/107701/how-can-i-remove-ds-store-files-from-a-git-repository

$ vi ~/.gitignore_global # modify configs with below `ignore_macos.js` file $ git config --global core.excludesfile ~/.gitignore_global 

ignore_macos.js

# OSgeneratedfiles # ###################### .DS_Store.DS_Store? ._*.Spotlight-V100.Trashesehthumbs.dbThumbs.db

https://stackoverflow.com/questions/18393498/gitignore-all-the-ds-store-files-in-every-folder-and-subfolder

$ find . -name .DS_Store -print0 | xargs -0 git rm --ignore-unmatch echo".DS_Store">>~/.gitignore_global echo"._.DS_Store">>~/.gitignore_global echo"**/.DS_Store">>~/.gitignore_global echo"**/._.DS_Store">>~/.gitignore_global git config --global core.excludesfile ~/.gitignore_global 

#Ignore foldermac.DS_Store # OR.DS_Store._.DS_Store**/.DS_Store**/._.DS_Store