test: update windows module load error message#14950
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
richardlau approved these changes Aug 20, 2017
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
If it's possible that the libuv update gets backported to LTS then I wonder if it it would make it easier for @nodejs/lts if this was included in the libuv update PR but as a separate commit because they have to land together.
tniessen approved these changes Aug 20, 2017
gibfahn approved these changes Aug 20, 2017
2 tasks
refack approved these changes Aug 20, 2017
refack added the libuv 
jasnell approved these changes Aug 20, 2017
ContributorAuthor
cjihrig commented Aug 20, 2017
This commit is completely independent of the libuv update. However, the opposite is not true. There is no chance of the libuv update being backported without this, because the Windows CI will light up bright red. For that reason, I think it's fine to keep them as separate PRs. Technically, this is an error message change, so it could be considered semver major. However, it comes from a dependency, so Node doesn't really have any control there. |
ContributorAuthor
cjihrig commented Aug 22, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: nodejs#14866 PR-URL: nodejs#14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: nodejs/node#14866 PR-URL: nodejs/node#14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: nodejs/node#14866 PR-URL: nodejs/node#14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Sep 20, 2017
this needs to land with #14866 |
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message.
Refs: #14866
Refs: libuv/libuv#1116
cc: @bnoordhuis
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test