deps: update V8 to 6.2

[targos]

I'm opening this early to track the issues that need fixing.

Blocking issues

Compilation failure with Clang (macOS, FreeBSD)

• https://ci.nodejs.org/job/node-test-commit-osx/12322/nodes=osx1010/console
• https://ci.nodejs.org/job/node-test-commit-freebsd/11520/nodes=freebsd11-x64/console

Error

In file included from ../deps/v8/src/compiler/common-operator.cc:5: In file included from ../deps/v8/src/compiler/common-operator.h:8: In file included from ../deps/v8/src/assembler.h:38: In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/forward_list:173: In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/memory:602: /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/utility:318:37: error: no type named 'type' in 'std::__1::enable_if<false, void>'; 'enable_if' cannot be used to disable this declaration typename enable_if<is_convertible<_U1, _T1>::value && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../deps/v8/src/compiler/common-operator.h:137:62: note: in instantiation of member function 'std::__1::pair<unsigned int, const v8::internal::ZoneVector<v8::internal::MachineType> *>::pair' requested here using std::pair<uint32_t, const ZoneVector<MachineType>*>::pair; ^ ../deps/v8/src/base/functional.h:143:69: note: while substituting deduced template arguments into function template 'TypedObjectStateInfo' [with _U1 = unsigned int, _U2 = int] V8_INLINE size_t operator()(T const& v) const{return hash_value(v)} ^ ../deps/v8/src/compiler/operator.h:188:47: note: in instantiation of member function 'v8::base::hash<v8::internal::compiler::ObjectStateInfo>::operator()' requested here return base::hash_combine(this->opcode(), this->hash_(this->parameter())); ^ ../deps/v8/src/compiler/operator.h:169:3: note: in instantiation of member function 'v8::internal::compiler::Operator1<v8::internal::compiler::ObjectStateInfo, v8::internal::compiler::OpEqualTo<v8::internal::compiler::ObjectStateInfo>, v8::internal::compiler::OpHash<v8::internal::compiler::ObjectStateInfo> >::HashCode' requested here Operator1(Opcode opcode, Properties properties, const char* mnemonic, ^ ../deps/v8/src/compiler/common-operator.cc:1260:23: note: in instantiation of member function 'v8::internal::compiler::Operator1<v8::internal::compiler::ObjectStateInfo, v8::internal::compiler::OpEqualTo<v8::internal::compiler::ObjectStateInfo>, v8::internal::compiler::OpHash<v8::internal::compiler::ObjectStateInfo> >::Operator1' requested here return new (zone()) Operator1<ObjectStateInfo>( // -- ^ 

Windows test failure

• https://ci.nodejs.org/job/node-test-binary-windows/11061/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2008r2/console

This one is because we do not support building addons with VS2013 anymore. We need to stop testing this on Node >=9.0.0.

[targos]

CI: https://ci.nodejs.org/job/node-test-pull-request/10043/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/900/

[SteveCruise]

Greate！

[vsemozhetbyt]

Will it be semver-major or landed on Node.js 8 LTS?

[targos]

Semver-major

[targos]

I updated the OP with two main issues.

/cc @nodejs/build @nodejs/platform-macos @nodejs/platform-freebsd

[cjihrig]

FYI: I built this branch and ran the llnode test suite. All tests passed.

[MylesBorins]

@targos I've gone ahead and put in request to get all floated patches upstreamed / landed on 6.2

https://chromium-review.googlesource.com/c/v8/v8/+/666925
https://chromium-review.googlesource.com/c/v8/v8/+/666961

https://bugs.chromium.org/p/v8/issues/detail?id=6824
https://bugs.chromium.org/p/v8/issues/detail?id=6825
https://bugs.chromium.org/p/v8/issues/detail?id=6826

[MylesBorins]

One more CI job to see if the gclient thing is a real problem or not

https://ci.nodejs.org/job/node-test-commit-v8-linux/904/

[MylesBorins]

Here is an ABI-Smoker job being run against this current PR... it should break. If it works... we have a problem

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-abi-smoker/39/

[refack]

This one is because we do not support building addons with VS2013 anymore. We need to stop testing this on Node >=9.0.0.

@targos do you think the problems on VS_VERSION=vs2015-x86,label=win2008r2 is a bug in the build script?

[joaocgreis]

I'll update CI to not use VS2013 for Node 9.

[MylesBorins]

@mhdawson any idea why ci is breaking during gsync?

[targos]

Updated and removed the V8 backports. I think some of them still need to be merged to 6.2?

[addaleax]

@targos Which ones? If you’re talking about the ones from #15391, yeah, as internal refactoring + an API change I don’t think they would be eligible for merging into 6.2. Feel free to ask for it if you think otherwise…

[targos]

I'm talking about the ones linked in #15362 (comment)

[targos]

@addaleax I cherry-picked 8403d6b#diff-ff06109b32824fc20fec697f584a42e3 to this PR. Your other cherry-pick is already in 6.2.

[targos]

Does anyone have an idea about how we can fix the error with Clang?

[MylesBorins]

CI: https://ci.nodejs.org/job/node-test-pull-request/10137/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/916/

Haven't seen clang errors yet, perhaps they'll surface in above jobs

[targos]

You can see the error in the FreeBSD job. OSX is still pending.

[joaocgreis]

CI changed to not run Node >=9 on VS2013. This fixed the Windows issue in this PR. Here is a Windows CI run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/11804/

[vsemozhetbyt]

Refs: https://v8project.blogspot.com/2017/09/disabling-escape-analysis.html