doc: make mkdtemp example work on Windows#15408
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
cjihrig approved these changes Sep 14, 2017
doc/api/fs.md Outdated
| ```js | ||
| fs.mkdtemp('/tmp/foo-', (err, folder) =>{ | ||
| consttempFolder=process.platform==='win32'?process.env['TEMP'] :'/tmp'; |
vsemozhetbyt approved these changes Sep 14, 2017
BridgeAR approved these changes Sep 14, 2017
jasnell approved these changes Sep 14, 2017
lpinca reviewed Sep 14, 2017
| if (err) throw err; | ||
| console.log(folder); | ||
| // Prints: /tmp/foo-itXde2 | ||
| // Prints: /tmp/foo-itXde2 or C:\Users\...\AppData\Local\Temp\foo-itXde2 |
Member
There was a problem hiding this comment.
I think this is also incorrect for macOS.
Member
There was a problem hiding this comment.
This should not be blocking though, right? As a comment it should be fine as is? (I do not have a Mac to test this on my own)
Member
There was a problem hiding this comment.
Can confirm the tmp dir is different on macOS but ofc this comment should not block PR from landing.
lpinca approved these changes Sep 14, 2017
Member
BridgeAR commented Sep 19, 2017
Landed in 1ebde6e |
BridgeAR pushed a commit that referenced this pull request Sep 19, 2017
PR-URL: #15408Fixes: #14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
PR-URL: #15408Fixes: #14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
PR-URL: nodejs/node#15408Fixes: nodejs/node#14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
PR-URL: nodejs/node#15408Fixes: nodejs/node#14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
PR-URL: #15408Fixes: #14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
MylesBorins commented Oct 17, 2017
landed this on v6.x, please lmk if it is not relevant |
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #15408Fixes: #14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14960
Checklist
Affected core subsystem(s)
doc