Skip to content

Conversation

@BridgeAR
Copy link
Member

Ref #13862

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. v6.x labels Sep 21, 2017
@BridgeARBridgeARforce-pushed the backport-13862-to-v6.x branch from c0f68fe to f61906aCompareSeptember 21, 2017 00:52
@BridgeAR
Copy link
MemberAuthor

BridgeAR commented Sep 21, 2017

@MylesBorins we have a linter error on v6.x-staging

diff --git a/test/parallel/test-fs-readfile-unlink.js b/test/parallel/test-fs-readfile-unlink.js index aa17324963..203ea681e5 100644 --- a/test/parallel/test-fs-readfile-unlink.js+++ b/test/parallel/test-fs-readfile-unlink.js@@ -3,7 +3,6 @@ const common = require('../common'); const assert = require('assert'); const fs = require('fs'); const path = require('path'); -const dirName = path.resolve(common.fixturesDir, 'test-readfile-unlink'); const fileName = path.resolve(common.tmpDir, 'test.bin'); const buf = Buffer.alloc(512 * 1024, 42);

I am not sure how we should fix that. Should I just open a new PR against the branch?

@MylesBorins
Copy link
Contributor

@BridgeAR I fixed this in the staging branch. give it another rebase 😄

1. Rename private functions 2. Use destructuring 3. Remove obsolete comments PR-URL: nodejs#13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@BridgeARBridgeARforce-pushed the backport-13862-to-v6.x branch from f61906a to f428371CompareSeptember 21, 2017 15:19
@BridgeAR
Copy link
MemberAuthor

@MylesBorins rebased

MylesBorins pushed a commit that referenced this pull request Sep 22, 2017
1. Rename private functions 2. Use destructuring 3. Remove obsolete comments Backport-PR-URL: #15516 PR-URL: #13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 22, 2017
Backport-PR-URL: #15516 PR-URL: #13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 55a2bd2...a8b34d8

MylesBorins pushed a commit that referenced this pull request Sep 26, 2017
1. Rename private functions 2. Use destructuring 3. Remove obsolete comments Backport-PR-URL: #15516 PR-URL: #13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 26, 2017
Backport-PR-URL: #15516 PR-URL: #13862 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@BridgeARBridgeAR deleted the backport-13862-to-v6.x branch April 1, 2019 23:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertIssues and PRs related to the assert subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BridgeAR@MylesBorins@nodejs-github-bot