doc: fix outdated code sample in n-api.md#15581
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
code samples of napi_create_object and napi_property_descriptor were not updated to latest API.
nodejs-github-bot added doc 
lpinca approved these changes Sep 24, 2017
jasnell approved these changes Sep 25, 2017
jasnell pushed a commit that referenced this pull request Sep 26, 2017
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. PR-URL: #15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 26, 2017
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. PR-URL: #15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Sep 26, 2017
Landed in 0a050e9 |
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. PR-URL: #15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. PR-URL: nodejs/node#15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. PR-URL: nodejs#15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. Backport-PR-URL: #19447 PR-URL: #15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code sample of napi_create_object and napi_property_descriptor were
not updated to latest API. Ran into this problem while migrating NAN projects to N-API.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc