Skip to content

Conversation

@lpinca
Copy link
Member

Specify that NaN, Infinity, and -Infinity are no longer valid
values for the atime and mtime arguments.

Fixes: #15453

Checklist
Affected core subsystem(s)

doc

Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. Fixes: nodejs#15453
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Sep 29, 2017
@BridgeAR
Copy link
Member

Landed in c8a2143

@BridgeARBridgeAR closed this Oct 2, 2017
BridgeAR pushed a commit that referenced this pull request Oct 2, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. PR-URL: #15680Fixes: #15453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@lpincalpinca deleted the gh-15453 branch October 2, 2017 05:29
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. PR-URL: #15680Fixes: #15453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 3, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. PR-URL: #15680Fixes: #15453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
lpinca added a commit to lpinca/node that referenced this pull request Oct 4, 2017
Fixes YAML parsing issues introduced in c8a2143. Refs: nodejs#15680
@lpincalpinca mentioned this pull request Oct 4, 2017
2 tasks
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. PR-URL: nodejs/node#15680Fixes: nodejs/node#15453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@vsemozhetbytvsemozhetbyt mentioned this pull request Oct 5, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 5, 2017

This PR possibly breaks doc building.

Refs:
#15447
#14930 (comment)

@lpinca
Copy link
MemberAuthor

lpinca commented Oct 5, 2017

@vsemozhetbyt#15769 has enough LGTMs and it's a trivial change. Feel free to land it if you have time.

@vsemozhetbyt
Copy link
Contributor

Fixing PR: #15788

@vsemozhetbyt
Copy link
Contributor

Oops, sorry, did not see that, I will close mine and land yours,

vsemozhetbyt pushed a commit that referenced this pull request Oct 5, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: #15769 Refs: #15680 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: #15769 Refs: #15680 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. PR-URL: #15680Fixes: #15453 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: #15769 Refs: #15680 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: nodejs/node#15769 Refs: nodejs/node#15680 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.utimes Infinity support is misdocumented or regressed

7 participants

@lpinca@BridgeAR@vsemozhetbyt@jasnell@cjihrig@MylesBorins@nodejs-github-bot