Use common fixtures.#15939
Closed
Use common fixtures. #15939
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added the code-and-learn 
BridgeAR reviewed Oct 7, 2017
Member
There was a problem hiding this comment.
This should use the fixtures.readKey function instead.
Member
There was a problem hiding this comment.
For instance,
key: fixtures.readKey('agent1-key.pem'),cert: fixtures.readKey('agent1-cert.pem')
Member
joyeecheung commented Oct 13, 2017
Ping @markexperience Can you take a look at #15939 (comment) ? |
Author
markexperience commented Oct 13, 2017 via email
Unfortunately was roped into jury duty, so I'm mostly unavailable for next 2 weeks or so. I'll see if I can address it this weekend. Mark W …On Oct 13, 2017 7:46 AM, "Joyee Cheung" ***@***.***> wrote: Ping @markexperience <https://github.com/markexperience> Can you take a look at #15939 (comment) <#15939 (comment)> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15939 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEchgwstTaTjCA2tLk1VssPmVXDOsjGbks5sr02ugaJpZM4Pwzlo> . |
Member
Trott commented Oct 27, 2017
I went ahead and force-pushed the small changes requested. I think this is ready to go. PTAL. |
joyeecheung approved these changes Oct 27, 2017
gireeshpunathil approved these changes Oct 27, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 27, 2017
PR-URL: nodejs#15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Member
Trott commented Oct 27, 2017
Landed in c66e555. Thanks for the contribution! 🎉 |
Member
tniessen commented Oct 28, 2017
@markexperience It seems like the email address you used to commit is not associated with your GitHub account. You can add the email address you used to commit in the GitHub settings. |
Member
gibfahn commented Oct 29, 2017
It's the |
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
PR-URL: #15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
PR-URL: #15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
PR-URL: #15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
PR-URL: nodejs/node#15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
PR-URL: nodejs/node#15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#15939 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use fixtures from the fixtures module.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes(https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)
Affected core subsystem(s)
test - parallels