test: assert.strictEqual message uses literals to include failing data#15944
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added the code-and-learn 
lance approved these changes Oct 7, 2017
Member
There was a problem hiding this comment.
Thanks for the contribution!
Minor nit, and this can be address when the PR lands, but be sure to check out the commit message guidelines. In this case, affected core subsystem would be test, and the first line of the commit should be less than 50 characters.
BridgeAR reviewed Oct 7, 2017
Member
There was a problem hiding this comment.
The line length exceeds 80 characters and has to be fixed. This could be done while landing as well though.
ContributorAuthor
Member
There was a problem hiding this comment.
It would have been great if you would have also changed this to reflect the line length ^^
jmcgui05force-pushed the process-disconnect-fix branch from 1ffb088 to d12b6ffCompare
jmcgui05force-pushed the process-disconnect-fix branch from d12b6ff to 94586ceCompare
BridgeAR approved these changes Oct 9, 2017
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
PR-URL: #15944 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
BridgeAR commented Oct 9, 2017
Landed in b2e46c5 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15944 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#15944 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
PR-URL: #15944 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
PR-URL: #15944 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #15944 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)