Skip to content

src: use maybe versions of methods#16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
boutell wants to merge 1 commit into from
Closed

src: use maybe versions of methods #16005

boutell wants to merge 1 commit into from

Conversation

@boutell
Copy link

@boutellboutell commented Oct 6, 2017•
edited
Loading

Invoke newer "maybe" versions of methods for which the old versions have been deprecated, throughout inspector_agent.cc.

Tests exist in test-inspector.js and are passing. If these tests are not sufficiently relevant let me now where I might begin supplying more specific coverage.

Affected core subsystems: inspector.

Implements #15864.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Oct 6, 2017
bnoordhuis
bnoordhuis approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@bnoordhuisbnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/10437/

@targostargos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
TimothyGu
TimothyGu approved these changes Oct 7, 2017
View reviewed changes
Copy link
Member

@TimothyGuTimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit looks good.

I commented on two nits, but there's no need to fix them -- we can handle them while landing this PR -- but if you can fix them that'd be even better!

src/inspector_agent.cc Outdated
Copy link
Member

@TimothyGuTimothyGuOct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: one space after =

src/inspector_agent.cc Outdated
Copy link
Member

@TimothyGuTimothyGuOct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we would generally write it this way:

 Local<Value> emit_fn = process_object->Get(context, FIXED_ONE_BYTE_STRING(isolate, "emit")) .ToLocalChecked();

@BridgeAR
Copy link
Member

BridgeAR commented Oct 18, 2017

@boutell would you be so kind and please rebase? This contains conflicts at the moment

@Trott
Copy link
Member

Trott commented Oct 27, 2017

Hi, everyone! I rebased to get rid of the merge conflict, and I also took care of @TimothyGu's nits while I was in there. This should be good to go. PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/11012/

bnoordhuis
bnoordhuis approved these changes Oct 27, 2017
View reviewed changes
src/inspector_agent.cc
Local<Object> process_object = parent_env_->process_object();
Local<Value> emit_fn =
process_object->Get(FIXED_ONE_BYTE_STRING(isolate, "emit"));
process_object->Get(context, FIXED_ONE_BYTE_STRING(isolate, "emit"))
Copy link
Member

@bnoordhuisbnoordhuisOct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro-nit: indent by 4 spaces (line continuation)

Copy link
Member

@tniessentniessenOct 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed while landing.

@tniessen
Copy link
Member

tniessen commented Oct 28, 2017

Landed in 2e8c04b, thank you! 🎉

tniessen pushed a commit that referenced this pull request Oct 28, 2017
@tniessen
src: use maybe versions of methods
2e8c04b
PR-URL: #16005Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@gibfahn
src: use maybe versions of methods
7b434ad
PR-URL: #16005Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@gibfahn
src: use maybe versions of methods
2cfb320
PR-URL: #16005Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@gibfahn
src: use maybe versions of methods
a194d83
PR-URL: #16005Fixes: #15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@gibfahngibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@Qard
src: use maybe versions of methods
2372a1c
PR-URL: nodejs/node#16005Fixes: nodejs/node#15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@Qard
src: use maybe versions of methods
ee3912e
PR-URL: nodejs/node#16005Fixes: nodejs/node#15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@addaleax
src: use maybe versions of methods
82e94ca
PR-URL: nodejs/node#16005Fixes: nodejs/node#15864 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen left review comments

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@TimothyGuTimothyGuTimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@boutell@BridgeAR@Trott@tniessen@bnoordhuis@jasnell@addaleax@TimothyGu@targos@cjihrig@MylesBorins@nodejs-github-bot